From 733506aed74c31f8bf868b6350e4f676ffcf6dc4 Mon Sep 17 00:00:00 2001 From: JustAnotherArchivist Date: Tue, 14 Jul 2020 01:14:17 +0000 Subject: [PATCH] Remove obsolete TODO MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The fnctl.flock call does not use LOCK_NB, so if it fails with an OSError, that is Really Badâ„¢ and can't be handled cleanly. --- qwarc/warc.py | 1 - 1 file changed, 1 deletion(-) diff --git a/qwarc/warc.py b/qwarc/warc.py index 1aa1ec3..8241850 100644 --- a/qwarc/warc.py +++ b/qwarc/warc.py @@ -256,7 +256,6 @@ class WARC: def _write_meta_warc(self, callback): filename = f'{self._prefix}-meta.warc.gz' - #TODO: Handle OSError on fcntl.flock and retry self._file = open(filename, 'ab') try: fcntl.flock(self._file.fileno(), fcntl.LOCK_EX)