Browse Source

Remove obsolete TODO

The fnctl.flock call does not use LOCK_NB, so if it fails with an OSError, that is Really Bad™ and can't be handled cleanly.
master
JustAnotherArchivist 3 years ago
parent
commit
733506aed7
1 changed files with 0 additions and 1 deletions
  1. +0
    -1
      qwarc/warc.py

+ 0
- 1
qwarc/warc.py View File

@@ -256,7 +256,6 @@ class WARC:

def _write_meta_warc(self, callback):
filename = f'{self._prefix}-meta.warc.gz'
#TODO: Handle OSError on fcntl.flock and retry
self._file = open(filename, 'ab')
try:
fcntl.flock(self._file.fileno(), fcntl.LOCK_EX)


Loading…
Cancel
Save